Add CPRNG #28
Merged
Add CPRNG #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI pipeline
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a cryptographically secure pseudo-random number generator (CPRNG) to the rtcompare package, providing an alternative to the existing deterministic DPRNG for scenarios requiring cryptographic-strength randomness or unpredictable inputs.
Key changes:
- New CPRNG implementation backed by crypto/rand with buffered reads for performance
- Integration of CPRNG into bootstrap sampling (activated when seed=0)
- Addition of F2T helper function for converting multiplicative speedup factors to threshold values
- Documentation updates across README and inline comments
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cprng.go | Implements the new CPRNG type with buffered crypto/rand reads and methods for generating various random number types (Uint64, Float64, Uint32N, etc.) |
| cprng_test.go | Comprehensive test suite including uniformity tests using chi-squared statistics, bounds checking, and performance comparison tests |
| rtcompare.go | Updates bootstrapSample to use CPRNG when prngSeed=0; adds F2T helper function; improves documentation for RTcomparisonResult and bootstrap functions |
| rtcompare_test.go | Adds test for high relative gains (>100% speedup) using deterministic identical samples |
| dprng.go | Fixes spelling errors in comments ("randum" → "random") and clarifies thread-safety documentation |
| README.md | Documents the new CPRNG feature and explains when to use DPRNG vs CPRNG |
| .gitignore | Adds .DS_Store to ignore macOS system files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Critical bug: When prngSeed is non-zero, every call to bootstrapSample in the loop will create a new DPRNG with the same seed, causing all bootstrap resamples to be identical. This defeats the purpose of bootstrap resampling. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Tom Tonic <tom@tomtonic.de>
Co-authored-by: TomTonic <20836927+TomTonic@users.noreply.github.com>
Co-authored-by: TomTonic <20836927+TomTonic@users.noreply.github.com>
Add test coverage for F2T function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.