Jrwrigh/mpich support #89
Merged
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMelt
requested changes
Jan 14, 2026
Owner
TomMelt
left a comment
TomMelt
left a comment
There was a problem hiding this comment.
Thanks @jrwrigh for this PR. I am happy to merge. Could you just update it so it passes the style test.
You can see what tests are run in the contributing guide https://github.com/TomMelt/mdb/blob/main/CONTRIBUTING.md#coding-conventions
The version of black I use it the one in the pyproject.toml. Currently is is black==24.3.0
jrwrigh
force-pushed
the
jrwrigh/mpich_support
branch
from
466385c to
d77ba81
Compare
Contributor
Author
|
Fixed up the formatting and it passes locally. Let me know if there's anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MPICH support.
Also switches to Python
Enumin the backend.Closes #65