Fix macOS app launch issues with ad-hoc signing#61
Open
mdsakalu wants to merge 1 commit intoTkaixiang:trunkfrom
Open
Fix macOS app launch issues with ad-hoc signing#61mdsakalu wants to merge 1 commit intoTkaixiang:trunkfrom
mdsakalu wants to merge 1 commit intoTkaixiang:trunkfrom
Conversation
Add missing entitlements required for Electron's crashpad to work properly on macOS when the app is ad-hoc signed (not notarized): - com.apple.security.cs.disable-library-validation - com.apple.security.get-task-allow Also add the entitlements config to electron-builder so entitlements are applied to the main app bundle, not just inherited by child processes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Does this degrade the app in any way? If not should it be the default on master or should we somehow aim for a "community signed" edition ? |
Owner
|
Hey, thanks for this PR. I would appreciate the help of anyone with a MacOS device to test this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entitlementsconfig to electron-builder so entitlements are applied to the main app bundle, not just inherited by child processesProblem
When building MarkText without an Apple Developer certificate, the app is ad-hoc signed. On recent macOS versions, the app would bounce in the dock but never open a window, with crashpad errors like:
Solution
Added two entitlements to
build/mac/entitlements.mac.plist:com.apple.security.cs.disable-library-validationcom.apple.security.get-task-allowAnd configured electron-builder to apply these entitlements to the main app bundle.
Testing
npm run build:macxattr -cror manualcodesigncodesign -d --entitlements - dist/mac-arm64/marktext.app🤖 Generated with Claude Code