Skip to content

Conversation

@masterfloda
Copy link

@masterfloda masterfloda commented Mar 9, 2018

  • SDK: added the AlertNotificationPolicy
  • SDK: get, create, update and delete methods
  • examples: alerts folder with examples for getting and deleting and the use case of silencing alerts

https://tintri.github.io/tintri-rest-api/client/http/docs/gen_api_doc/jaxrs/v310/v310/alert/notificationPolicy/index.html

@mgritter
Copy link
Contributor

This looks good. I have a couple things I need to figure out, though.

  1. The way we pushed to github doesn't actually allow the library to be rebuilt. I have to fix our internal tooling (and move your changes to our internal repo) before we can push a new version.

  2. I am not sure whether there is a more efficient way to implement the methods you added using the "@api" decorator or not. It seems to me that at least some of the methods could be done in a more idiomatic fashion by specifying an appropriate filter type. I'll try to figure this out.

@rehrhart
Copy link

rehrhart commented Mar 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants