Skip to content

Added imports to PluginListInterface File #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinder-SamMarshall merged 3 commits into from
Mar 26, 2025
Merged

Added imports to PluginListInterface File #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38ccea8
Added imports to PluginListInterface File
tinder-SamMarshall Mar 25, 2025
6d00ade
Added more configs
tinder-SamMarshall Mar 26, 2025
7623142
Fixed tests
tinder-SamMarshall Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Customization/Configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ dependencyInjectionImports:
builderImports: []
flowImports: []
pluginListImports: []
pluginListInterfaceImports: []
viewControllerImports: []
dependencies: []
analyticsProperties: []
Expand Down
5 changes: 5 additions & 0 deletions Sources/NodesGenerator/Config.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public struct Config: Codable, Equatable {
public var flowImports: Set<String>
public var interfaceImports: Set<String>
public var pluginListImports: Set<String>
public var pluginListInterfaceImports: Set<String>
public var viewControllerImports: Set<String>
public var dependencies: [Variable]
public var analyticsProperties: [Variable]
Expand Down Expand Up @@ -97,6 +98,7 @@ extension Config {
flowImports = []
interfaceImports = []
pluginListImports = []
pluginListInterfaceImports = []
viewControllerImports = []
dependencies = []
analyticsProperties = []
Expand Down Expand Up @@ -176,6 +178,9 @@ extension Config {
pluginListImports =
(try? decoder.decode(CodingKeys.pluginListImports))
?? defaults.pluginListImports
pluginListInterfaceImports =
(try? decoder.decode(CodingKeys.pluginListInterfaceImports))
?? defaults.pluginListInterfaceImports
viewControllerImports =
(try? decoder.decode(CodingKeys.viewControllerImports))
?? defaults.viewControllerImports
Expand Down
1 change: 1 addition & 0 deletions Sources/NodesGenerator/StencilTemplate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ public enum StencilTemplate: CustomStringConvertible, Equatable, Sendable {
case .pluginListInterface:
config.baseImports
.union(["Nodes"])
.union(config.pluginListInterfaceImports)
case .pluginListTests:
config.baseTestImports
.union(["NodesTesting"])
Expand Down
3 changes: 3 additions & 0 deletions Tests/NodesGeneratorTests/ConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ final class ConfigTests: XCTestCase, TestFactories {
pluginListImports:
- <pluginListImports-1>
- <pluginListImports-2>
pluginListInterfaceImports:
- <pluginListInterfaceImports-1>
- <pluginListInterfaceImports-2>
viewControllerImports:
- <viewControllerImports-1>
- <viewControllerImports-2>
Expand Down
2 changes: 2 additions & 0 deletions Tests/NodesGeneratorTests/StencilTemplateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
case .pluginListInterface:
expect(imports) == [
"<baseImport>",
"<pluginListInterfaceImport>",
"Nodes"
]
case .pluginListTests:
Expand Down Expand Up @@ -496,6 +497,7 @@ final class StencilTemplateTests: XCTestCase, TestFactories {
case .pluginListInterface:
expect(imports) == [
"<baseImport>",
"<pluginListInterfaceImport>",
"Nodes"
]
case .pluginListTests:
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/Support/TestFactories.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ extension TestFactories {
config.flowImports = ["<flowImport>"]
config.interfaceImports = ["<interfaceImport>"]
config.pluginListImports = ["<pluginListImport>"]
config.pluginListInterfaceImports = ["<pluginListInterfaceImport>"]
config.viewControllerImports = ["<viewControllerImport>"]
config.dependencies = [Variable(name: "<dependencyName>", type: "<dependencyType>")]
config.analyticsProperties = [Variable(name: "<analyticsPropertyName>", type: "<analyticsPropertyType>")]
Expand Down
3 changes: 3 additions & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testConfig.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
▿ pluginListImports: 2 members
- "<pluginListImports-1>"
- "<pluginListImports-2>"
▿ pluginListInterfaceImports: 2 members
- "<pluginListInterfaceImports-1>"
- "<pluginListInterfaceImports-2>"
- publisherFailureType: "<publisherFailureType>"
- publisherType: "<publisherType>"
▿ reactiveImports: 2 members
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testConfigWithEmptyFileContents.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- isTestTemplatesGenerationEnabled: true
- isViewInjectedTemplateEnabled: true
- pluginListImports: 0 members
- pluginListInterfaceImports: 0 members
- publisherFailureType: "Never"
- publisherType: "AnyPublisher"
▿ reactiveImports: 1 member
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testDecodingFromEmptyString.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- isTestTemplatesGenerationEnabled: true
- isViewInjectedTemplateEnabled: true
- pluginListImports: 0 members
- pluginListInterfaceImports: 0 members
- publisherFailureType: "Never"
- publisherType: "AnyPublisher"
▿ reactiveImports: 1 member
Expand Down
1 change: 1 addition & 0 deletions Tests/NodesGeneratorTests/__Snapshots__/ConfigTests/testDecodingWithEmptyArray.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- isTestTemplatesGenerationEnabled: true
- isViewInjectedTemplateEnabled: true
- pluginListImports: 0 members
- pluginListInterfaceImports: 0 members
- publisherFailureType: "Never"
- publisherType: "AnyPublisher"
▿ reactiveImports: 1 member
Expand Down
3 changes: 2 additions & 1 deletion .../__Snapshots__/XcodeTemplatePermutationTests/testPluginListXcodeTemplatePermutation.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
- "<dependencyInjectionImport>"
- "<pluginListImport>"
- "Nodes"
▿ pluginListInterfaceImports: 2 elements
▿ pluginListInterfaceImports: 3 elements
- "<baseImport>"
- "<pluginListInterfaceImport>"
- "Nodes"
- pluginListName: "___VARIABLE_productName___"
▿ pluginListTestsImports: 2 elements
Expand Down
3 changes: 2 additions & 1 deletion Tests/NodesGeneratorTests/__Snapshots__/XcodeTemplateTests/testPluginListXcodeTemplate.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
- "<dependencyInjectionImport>"
- "<pluginListImport>"
- "Nodes"
▿ pluginListInterfaceImports: 2 elements
▿ pluginListInterfaceImports: 3 elements
- "<baseImport>"
- "<pluginListInterfaceImport>"
- "Nodes"
- pluginListName: "___VARIABLE_productName___"
▿ pluginListTestsImports: 2 elements
Expand Down