Apply standard Swift package configuration #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinder-garricnahapetian
previously approved these changes
Sep 18, 2024
tinder-cfuller
dismissed
tinder-garricnahapetian’s stale review
via
8487b3b
tinder-cfuller
commented
Sep 18, 2024
Collaborator
Author
There was a problem hiding this comment.
We can consider adding back the additional checks in separate workflows in a subsequent PR.
tinder-garricnahapetian
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following two issues prevent treating warnings as errors in GitHub workflows, so those options (
SWIFT_TREAT_WARNINGS_AS_ERRORSand-warnings-as-errors) have been removed for the time being.xcodebuildfailing witherror: conflicting options '-warnings-as-errors' and '-suppress-warnings'(impacting the Xcode and Genesis workflows only)These can be re-added again in the future if the issues can be resolved. A draft PR has been created proactively: #846