Skip to content

Handle missing M2M managers #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimurKady merged 1 commit into from
Nov 27, 2025
Merged

Handle missing M2M managers #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions freeadmin/contrib/adapters/tortoise/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,8 @@ async def m2m_clear(self, manager) -> None:

This coroutine must be awaited.
"""
if manager is None:
return
await manager.clear()

async def m2m_add(self, manager, objs: Iterable[Model]) -> None:
Expand All @@ -520,6 +522,8 @@ async def m2m_add(self, manager, objs: Iterable[Model]) -> None:

This coroutine must be awaited.
"""
if manager is None:
return
await manager.add(*objs)

def values(self, qs: QuerySet, *fields: str) -> QuerySet:
Expand Down
8 changes: 8 additions & 0 deletions freeadmin/core/interface/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,9 +1238,17 @@ def clean(
return data, m2m_ops

async def m2m_clear(self, manager):
"""Safely clear all links from the provided relation manager."""

if manager is None:
return
await self.adapter.m2m_clear(manager)

async def m2m_add(self, manager, objs: Iterable[Any]):
"""Attach ``objs`` to the provided relation manager when available."""

if manager is None:
return
await self.adapter.m2m_add(manager, objs)

async def create(
Expand Down