Fix for occasional seg fault #50
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This usually happens when 'U' (Selenocysteine) is found in a protein sequence.
The seg fault only seems to happen when called from the python bindings. Otherwise, it seems that the uninitialized memory is zero when calling the binary directly.
Currently, when a character is found that isn't in the alphabet, a warning is triggered but the loop continues, leaving the uninitialized memory in that array. This is later used in
lib/src/bpm.c:The fix tries to treat the unknown alphabet letters as ambiguous or it falls back to zeroing the memory.