Skip to content

Fix: Nested presets failing with 17+ files due to menu collision #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cypress-exe wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Fix: Nested presets failing with 17+ files due to menu collision #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Application/FileConverterExtension/FileConverterExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,11 @@ protected override ContextMenuStrip CreateMenu()
Image = new Icon(Properties.Resources.ApplicationIcon, SystemInformation.SmallIconSize).ToBitmap(),
};

int menuItemIndex = 0;
foreach (MenuEntry menuEntry in this.menuEntries)
{
menuItemIndex++;

ToolStripMenuItem root = fileConverterItem;
if (menuEntry.PresetReference.Folders != null)
{
Expand Down Expand Up @@ -142,9 +145,14 @@ protected override ContextMenuStrip CreateMenu()
root = fileConverterItem;
}

// Make each menu item text unique using invisible zero-width spaces
// This prevents Windows Forms menu collision while being completely invisible to users
string uniqueSuffix = new string('\u200B', menuItemIndex); // Zero-Width Space characters
string displayText = menuEntry.PresetReference.Name + uniqueSuffix;

ToolStripMenuItem subItem = new ToolStripMenuItem
{
Text = menuEntry.PresetReference.Name,
Text = displayText,
Enabled = menuEntry.Enabled
};

Expand Down