monitoring: Funder Change Detection #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshll1001
requested changes
Dec 3, 2025
mrshll1001
left a comment
mrshll1001
left a comment
There was a problem hiding this comment.
This is fine to merge, however Rikki and I have discussed how certain decisions and context can be represented in comments, as well as tweaking a few variable names for clarity.
R2ZER0
force-pushed
the
rg/monitoring-funder-change-detection
branch
from
29fbf48 to
433f03b
Compare
This commit adds an endpoint to the monitoring API which lists the funder records that have changed between two given dates, along with the nature of the changes made.
This commit: * Refactors the change detection algorithm out into smaller helper functions * Adds comments for clarity on purpose * Renames and uppercase AbstractMetricRecord overridable constants
R2ZER0
force-pushed
the
rg/monitoring-funder-change-detection
branch
from
433f03b to
b3222ce
Compare
mrshll1001
approved these changes
Dec 5, 2025
mrshll1001
left a comment
mrshll1001
left a comment
There was a problem hiding this comment.
Nice. Thanks for adding useful context comments @R2ZER0 . This is fine for merge :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an endpoint to the monitoring API which lists the funder records that have changed between two given dates, along with the nature of the changes made.