Use registration token to prevent double target id use #33
+101
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustybee42
force-pushed
the
rb/registration-prevent-id-reuse
branch
3 times, most recently
from
ae4c5cf to
3c90917
Compare
rustybee42
force-pushed
the
rb/registration-prevent-id-reuse
branch
from
3c90917 to
1ebfc99
Compare
rustybee42
force-pushed
the
rb/registration-prevent-id-reuse
branch
from
1ebfc99 to
35cac3a
Compare
philippfalk
approved these changes
Jan 14, 2026
Member
philippfalk
left a comment
philippfalk
left a comment
There was a problem hiding this comment.
Changes look good after some discussion and fixing of some corner cases.
Basic tests work as expected:
- Upgrade to new database version adds empty column
- Starting legacy meta services doesn't add registration tokens
- First start of a patched meta adds registration tokens
- Storage target registrations add tokens without updates needed to storage service
rustybee42
force-pushed
the
rb/registration-prevent-id-reuse
branch
from
4562878 to
4ed2e6d
Compare
On storage target registration, the node sends a "node string id" / alias which is generated locally on the node. This commit uses that as a registration token to "ensure" that a once registered target id is not reused with a different target - if the registration token is already known, the RegisterNodeMsg will fail. This restores old managements behavior. Note that the RegisterNodeMsg actually doesn't do anything on an already known target (and didn't before this commit) besides logging. It is up to the server nodes to abort on a failing RegisterNodeMsg.
This takes the previously ignored node_alias field on received heartbeats from meta nodes (only!) and stores it together with the meta target as a registration token. When the field is already filled, a mismatch will fail the heartbeat.
rustybee42
force-pushed
the
rb/registration-prevent-id-reuse
branch
from
4ed2e6d to
66e4acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On storage target registration, the node sends a "node string id" / alias which is generated locally on the node. This commit uses that as a registration token to "ensure" that a once registered target id is not reused with a different target - if the registration token is already known, the RegisterNodeMsg will fail. This restores old managements behavior.
Note that the RegisterNodeMsg actually doesn't do anything on an already known target (and didn't before this commit) besides logging. It is up to the server nodes to abort on a failing RegisterNodeMsg.
Closes #22
Related to https://github.com/ThinkParQ/beegfs-core/pull/4486