Skip to content

Fix chart bucketing logic #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genewoo merged 1 commit into from
Jun 5, 2025
Merged

Fix chart bucketing logic #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hrm/bt_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def build_heart_rate_chart(self, since_from: float = 600.0) -> str:

bucket_len = since_from / bucket_size
if bucket_len > 60:
bucket_size = int(since_from / 60)
bucket_size = math.ceil(since_from / 60)
else:
bucket_size = 1
data = self.get_heart_rate_bucket(
Expand Down
14 changes: 14 additions & 0 deletions tests/mcp/test_bt_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,20 @@ def fake_savefig(buf, format=None):
mock_plt.savefig.assert_called()


@patch("hrm.bt_client.upload_file", return_value="http://fake.url/chart.png")
@patch("hrm.bt_client.plt")
def test_build_heart_rate_chart_bucket_size(mock_plt, mock_upload_file, bt_client):
with patch.object(
bt_client,
"get_heart_rate_bucket",
return_value=[{"time": 1, "value": 60}],
) as mock_bucket:
since = 100.0
url = bt_client.build_heart_rate_chart(since_from=since)
assert url == "http://fake.url/chart.png"
mock_bucket.assert_called_once_with(since_from=since, bucket_size=math.ceil(since / 60))


def test_upload_file_success(monkeypatch):
# Set up environment variables
monkeypatch.setenv("QINIU_ACCESS_KEY", "fake_key")
Expand Down