Open
Conversation
Comment on lines
215
to
219
| def setUp(self): | ||
| super().setUp() | ||
| self.post = Post.objects.create( | ||
| author=self.author, title="test title", text="test text" | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| def setUp(self): | |
| super().setUp() | |
| self.post = Post.objects.create( | |
| author=self.author, title="test title", text="test text" | |
| ) | |
| def setUp(self): | |
| super().setUp() |
TestPostMixin의 _create_post을 쓰면 될거 같음~(중복)
|
|
||
| def test_post_delete_with_error_with_post_on_404(self): | ||
| # Given: 삭제 하기 위한 유효하지 않은 post_id 값이 주어지고, | ||
| request_body = json.dumps({"author": self.author.id}) |
Contributor
There was a problem hiding this comment.
nitpick, 주석 내용이랑 맞지 않는 부분이네 # And: 로 따로 빼던지 현재 주석 내용을 좀 더 포괄적으로 적어주면 좋을것 같음
-> 주석 내용이랑 코드가 다르면, 코드 읽는 사람에게 혼란을 주고, 두번세번 더 읽어봐야함
Collaborator
Author
|
넵 확인했습니다 |
9a69ce2 to
043b6d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.