Skip to content

Conversation

@SorraTheOrc
Copy link
Member

Summary:\n- Update PRD docs/prd/GDD_M2_ai_assisted_branching.md to include ge-hch.5.16 runtime integration details: 12-state integration state machine, atomic checkpoint/rollback semantics, persistence/audit logging, and save/load branch history.\n\nFiles changed:\n- docs/prd/GDD_M2_ai_assisted_branching.md\n\nBeads / metadata:\n- Added 'Status: PRD Completed' label to bead ge-hch.5.16.\n\nQA / reviews performed:\n- Ran automated five-stage review: Structural, Clarity, Technical consistency (Open Question: pilot metric X), Security & compliance (added mitigation notes), and Lint/style (remark fixes). Edits are conservative and non-intent-changing.\n\nNotes / next actions:\n- Remaining Open Questions: save metadata fields, story-specific policy overrides, pilot operator-intervention metric X.\n- Next: create implementation tasks for runtime hook manager, state machine, checkpointing API, save metadata schema, and tests (optional).

- Create tests/director.smoke.spec.ts with comprehensive Director telemetry tests
  * Test director_decision events during playthrough
  * Verify threshold tuning (high vs low approval rates)
  * Verify Director disabled falls back to naive injection
  * Assert telemetry fields (decision, reason, riskScore, latencyMs)
  * Measure Director latency (target <500ms per decision)

- Update web/stories/manifest.schema.json with test metadata fields
  * testable (boolean): marks story as suitable for smoke tests
  * aiEnabled (boolean): marks story as having AI branch capability
  * aiChoiceCount (integer): hint for expected AI choice points

- Create web/stories/manifest.json with testable stories
  * demo.ink (testable, aiEnabled, 5 expected AI choices)
  * test.ink (testable, not aiEnabled)
  * test_minimal.ink (testable, not aiEnabled)

Test design leverages existing utilities from demo.telemetry.spec.ts and
reuses Director UI controls (#director-enabled, #director-risk-threshold).
Story selection uses manifest.json to load first testable story with AI enabled.
Tests now use hardcoded manifest structure instead of fetching /stories/manifest.json,
which resolves URL parsing issues in test environment. This is safe since manifest
structure is static and defined in the acceptance criteria.
@SorraTheOrc SorraTheOrc merged commit f5c2027 into main Jan 19, 2026
4 checks passed
@SorraTheOrc SorraTheOrc deleted the feature/ge-3gh-director-smoke-test branch January 19, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants