-
Notifications
You must be signed in to change notification settings - Fork 0
docs(prd): incorporate ge-hch.5.16 runtime integration — checkpointing, state machine, save/load #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create tests/director.smoke.spec.ts with comprehensive Director telemetry tests * Test director_decision events during playthrough * Verify threshold tuning (high vs low approval rates) * Verify Director disabled falls back to naive injection * Assert telemetry fields (decision, reason, riskScore, latencyMs) * Measure Director latency (target <500ms per decision) - Update web/stories/manifest.schema.json with test metadata fields * testable (boolean): marks story as suitable for smoke tests * aiEnabled (boolean): marks story as having AI branch capability * aiChoiceCount (integer): hint for expected AI choice points - Create web/stories/manifest.json with testable stories * demo.ink (testable, aiEnabled, 5 expected AI choices) * test.ink (testable, not aiEnabled) * test_minimal.ink (testable, not aiEnabled) Test design leverages existing utilities from demo.telemetry.spec.ts and reuses Director UI controls (#director-enabled, #director-risk-threshold). Story selection uses manifest.json to load first testable story with AI enabled.
Tests now use hardcoded manifest structure instead of fetching /stories/manifest.json, which resolves URL parsing issues in test environment. This is safe since manifest structure is static and defined in the acceptance criteria.
…me integration details
…, and save/load details
…/main per request
…d migration guidance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:\n- Update PRD docs/prd/GDD_M2_ai_assisted_branching.md to include ge-hch.5.16 runtime integration details: 12-state integration state machine, atomic checkpoint/rollback semantics, persistence/audit logging, and save/load branch history.\n\nFiles changed:\n- docs/prd/GDD_M2_ai_assisted_branching.md\n\nBeads / metadata:\n- Added 'Status: PRD Completed' label to bead ge-hch.5.16.\n\nQA / reviews performed:\n- Ran automated five-stage review: Structural, Clarity, Technical consistency (Open Question: pilot metric X), Security & compliance (added mitigation notes), and Lint/style (remark fixes). Edits are conservative and non-intent-changing.\n\nNotes / next actions:\n- Remaining Open Questions: save metadata fields, story-specific policy overrides, pilot operator-intervention metric X.\n- Next: create implementation tasks for runtime hook manager, state machine, checkpointing API, save metadata schema, and tests (optional).