Skip to content

Prevent empty installer directory creation in build script#155

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/add-files-from-logs-if-not-empty
Draft

Prevent empty installer directory creation in build script#155
Copilot wants to merge 2 commits intomasterfrom
copilot/add-files-from-logs-if-not-empty

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

The move-vsix-to-installer.js build script unconditionally created the installer directory, even when no .vsix files existed to move.

Changes

  • Collect .vsix files before directory creation
  • Only create installer directory when files exist to move (vsixFiles.length > 0)

Before:

if (!fs.existsSync(installerDir)) {
    fs.mkdirSync(installerDir);
}
fs.readdirSync('.').filter(f => f.endsWith('.vsix')).forEach(...)

After:

const vsixFiles = fs.readdirSync('.').filter(f => f.endsWith('.vsix'));
if (vsixFiles.length > 0) {
    if (!fs.existsSync(installerDir)) {
        fs.mkdirSync(installerDir);
    }
    vsixFiles.forEach(...)
}
Original prompt

add files from logs only if folders contains any files


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: norschel <12895005+norschel@users.noreply.github.com>
Copilot AI changed the title [WIP] Add files from logs only if folders contain files Prevent empty installer directory creation in build script Feb 6, 2026
Copilot AI requested a review from norschel February 6, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants