Invalidate cloudfront on main branch #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds CloudFront cache invalidation to the deployment workflow, ensuring that changes deployed to the main branch are immediately visible by invalidating the CloudFront distribution cache.
- Adds a new workflow step to invalidate CloudFront distribution after S3 deployment
- Invalidation only runs on the main branch to match production deployments
- Uses the same AWS credentials pattern as the existing S3 deployment step
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Invalidate CloudFront distribution on main branch | ||
| if: github.ref == 'refs/heads/main' | ||
| run: | | ||
| aws cloudfront create-invalidation --distribution-id E12E3K1OI02YXE --paths "/*" |
There was a problem hiding this comment.
Consider storing the CloudFront distribution ID as a repository secret or environment variable instead of hardcoding it. This would improve security and maintainability, especially if the distribution ID needs to change or if you want to use different distributions for different environments.
Example:
run: |
aws cloudfront create-invalidation --distribution-id ${{ secrets.CLOUDFRONT_DISTRIBUTION_ID }} --paths "/*"
Suggested change
| aws cloudfront create-invalidation --distribution-id E12E3K1OI02YXE --paths "/*" | |
| aws cloudfront create-invalidation --distribution-id ${{ secrets.CLOUDFRONT_DISTRIBUTION_ID }} --paths "/*" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.