Relax schema.org model validation to accept fields with and without namespace prefix#3067
Merged
jonathangreen merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
…prefix Use AliasChoices for validation aliases so fields like "bookFormat" and "schema:bookFormat" are both accepted during parsing. Relax the Audience type field from a Literal to an optional string for flexibility.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 93.18% 93.18% -0.01%
==========================================
Files 489 489
Lines 44943 44942 -1
Branches 6191 6191
==========================================
- Hits 41880 41879 -1
Misses 1986 1986
Partials 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the schema.org Pydantic models to use
AliasChoicesfor validation aliases, so fields can be parsed with or without theschema:namespace prefix (e.g., both"bookFormat"and"schema:bookFormat"are accepted). Serialization still uses theschema:prefixed form.Also relaxes the
Audience.typefield fromLiteral["schema:PeopleAudience"]tostr | Nonefor flexibility with varying feed data.Motivation and Context
Some OPDS feeds provide schema.org fields without the
schema:namespace prefix, which caused validation failures. See this Slack thread for details.How Has This Been Tested?
Existing tests continue to pass. The changes are additive — previously accepted input is still accepted, and additional input formats are now supported.
Checklist