Open
Conversation
Joseph-DiGiovanni
force-pushed
the
matched-functions
branch
from
599bf4f to
bf575e6
Compare
Joseph-DiGiovanni
force-pushed
the
matched-functions
branch
from
e2e5bcc to
ab8c21d
Compare
Joseph-DiGiovanni
force-pushed
the
matched-functions
branch
from
ba391db to
58495b7
Compare
Joseph-DiGiovanni
force-pushed
the
matched-functions
branch
from
153a121 to
da5ea0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
qwordtype to force lq/sq instructions when copying 16 byte structs. There was an existing typedef inmemory.cfor the same purpose so I moved it totypes.hfor broader usage. According to Ghidra, there is a seemingly unused type in the prototype calledqwordso I assume this is the original purpose and name in the source code.CLQandBEIstructs seem to be complete and fully understood now as well.I used inline functions since it made the code cleaner and Ghidra hints at inline code at the same locations in the prototype code.