Support unfamiliar locales #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoblomj
force-pushed
the
support-unfamiliar-locales
branch
2 times, most recently
from
c0e5680 to
f889c85
Compare
sjoblomj
force-pushed
the
support-unfamiliar-locales
branch
from
f889c85 to
e031836
Compare
Collaborator
|
Going to have a look at #134 #136 and #137. Do you have a selection of MPQ archives that implement locales? Or which games they are used in? I only have WoW Vanilla, TBC and WoTLK archives/patches - so limited on testing. I have created a couple, but would like to see some original examples. Also, what game that are commonly used with would also be useful, then I can download some examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests will now make their own MPQ without an internal listfile, which builds on top of #134. This PR should thus be merged after #134, and the diff will be very large before it is merged.
In this PR: