Add a poem word element so we can render individual poem words directly#5
Open
Veovis-Muaddib wants to merge 4 commits intoTheFloydman:masterfrom
Open
Add a poem word element so we can render individual poem words directly#5Veovis-Muaddib wants to merge 4 commits intoTheFloydman:masterfrom
Veovis-Muaddib wants to merge 4 commits intoTheFloydman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next step is to create an element and register that element with Guidebook, but Guidebook is not set up to allow external registrations, so this PR is pending another PR to be created there.
Specifically the elements are parsed by name in an if/else block here. the pull request would add a String->(Element? ElementParser?) mapping with a public registration method to allow us to register additional elements.