Skip to content

Comments

Remove unnecessary null check for EKCalendar.CGColor#87

Merged
TheAlmightyBob merged 1 commit intomasterfrom
RemoveExtraNullCheck
Feb 8, 2022
Merged

Remove unnecessary null check for EKCalendar.CGColor#87
TheAlmightyBob merged 1 commit intomasterfrom
RemoveExtraNullCheck

Conversation

@TheAlmightyBob
Copy link
Owner

It is now indicated by the SDK as being non-nullable.

(This was also addressed by @chrfin in #85, but isn't actually related to the rest of that PR. In that case, in the interest of caution, @maxkoshevoi suggested using null! to keep the check... which was a good idea, but since the Swift documentation lists it as CGColor!, I think it is safe to trust that the updated type is correct and it won't be null... and the unit tests should catch if that's wrong)

@TheAlmightyBob
Copy link
Owner Author

Obviously Android, a platform untouched by this PR, is the one that fails.... 😑

@TheAlmightyBob
Copy link
Owner Author

Damn, I tried creating a GitHub Action to build Android, and it fails with the exact same error.... nothing has changed in the project since the last successful CI builds, what the heck happened??

@maxkoshevoi
Copy link
Contributor

Damn, I tried creating a GitHub Action to build Android, and it fails with the exact same error.... nothing has changed in the project since the last successful CI builds, what the heck happened??

What is the error message (AppCenter runs are private)?

@TheAlmightyBob
Copy link
Owner Author

Damn, I tried creating a GitHub Action to build Android, and it fails with the exact same error.... nothing has changed in the project since the last successful CI builds, what the heck happened??

What is the error message (AppCenter runs are private)?

@maxkoshevoi Are you able to view the GitHub Action error in #88 ?

Anyhow, it's this:

/Users/runner/.dotnet/sdk/5.0.404/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(241,5): error NETSDK1004: Assets file '/Users/runner/work/Calendars/Calendars/Calendars/Calendars.Plugin.Abstractions/obj/project.assets.json' not found. Run a NuGet package restore to generate this file.

@chrfin
Copy link

chrfin commented Feb 7, 2022

I know this error from our DevOps builds at work:  
Calling dotnet restore before the build did help in our case...

@TheAlmightyBob
Copy link
Owner Author

TheAlmightyBob commented Feb 7, 2022

Calling dotnet restore before the build did help in our case...

I'm already restoring via nuget restore, but I can try dotnet restore... don't know what the difference is

(and of course I don't think I have any control there in AppCenter.... which I would still like to use if possible... perhaps its days are numbered, but I liked that it would actually try installing/booting the app as a basic check.... I haven't seen a GitHub action for that, though maybe it's possible...)

@chrfin
Copy link

chrfin commented Feb 7, 2022

I'm already restoring via nuget restore, but I can try dotnet restore... don't know what the difference is

...so did we 🤓. I think nuget does not work correctly with some of the new packages/projects, but dotnet does.

@TheAlmightyBob
Copy link
Owner Author

Well fascinating. @chrfin that did seem to fix the build in the GitHub action! Thanks.

I might see if I can use the prebuild scripts to do the same thing in AppCenter.... but if that doesn't work maybe this will be the time to give up on that and just switch to GitHub Actions....

It is now indicated by the SDK as being non-nullable.
@TheAlmightyBob TheAlmightyBob merged commit 4aba719 into master Feb 8, 2022
@TheAlmightyBob TheAlmightyBob deleted the RemoveExtraNullCheck branch February 14, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants