Remove unnecessary null check for EKCalendar.CGColor#87
Remove unnecessary null check for EKCalendar.CGColor#87TheAlmightyBob merged 1 commit intomasterfrom
Conversation
|
Obviously Android, a platform untouched by this PR, is the one that fails.... 😑 |
|
Damn, I tried creating a GitHub Action to build Android, and it fails with the exact same error.... nothing has changed in the project since the last successful CI builds, what the heck happened?? |
What is the error message (AppCenter runs are private)? |
@maxkoshevoi Are you able to view the GitHub Action error in #88 ? Anyhow, it's this:
|
|
I know this error from our DevOps builds at work: |
I'm already restoring via (and of course I don't think I have any control there in AppCenter.... which I would still like to use if possible... perhaps its days are numbered, but I liked that it would actually try installing/booting the app as a basic check.... I haven't seen a GitHub action for that, though maybe it's possible...) |
...so did we 🤓. I think |
|
Well fascinating. @chrfin that did seem to fix the build in the GitHub action! Thanks. I might see if I can use the prebuild scripts to do the same thing in AppCenter.... but if that doesn't work maybe this will be the time to give up on that and just switch to GitHub Actions.... |
It is now indicated by the SDK as being non-nullable.
d38d91e to
f29d8c5
Compare
It is now indicated by the SDK as being non-nullable.
(This was also addressed by @chrfin in #85, but isn't actually related to the rest of that PR. In that case, in the interest of caution, @maxkoshevoi suggested using
null!to keep the check... which was a good idea, but since the Swift documentation lists it asCGColor!, I think it is safe to trust that the updated type is correct and it won't benull... and the unit tests should catch if that's wrong)