Skip to content

AppVeyor Warnings #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thalhammer merged 3 commits into from
Dec 29, 2025
Merged

AppVeyor Warnings #403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff5ace
Add size checks before casting to int
JurgenLB Dec 19, 2025
be19407
Fix windows build without NOMINMAX
Thalhammer Dec 29, 2025
5035a4c
Merge branch 'master' into patch-1
Thalhammer Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions include/jwt-cpp/jwt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,13 +722,23 @@ namespace jwt {
if (key.substr(0, 27) == "-----BEGIN CERTIFICATE-----") {
auto epkey = helper::extract_pubkey_from_cert<error_category>(key, password, ec);
if (ec) return {};
const int len = static_cast<int>(epkey.size());
// Ensure the size fits into an int before casting
if (epkey.size() > static_cast<std::size_t>((std::numeric_limits<int>::max)())) {
ec = error_category::load_key_bio_write; // Add an appropriate error here
return {};
}
int len = static_cast<int>(epkey.size());
if (BIO_write(pubkey_bio.get(), epkey.data(), len) != len) {
ec = error_category::load_key_bio_write;
return {};
}
} else {
const int len = static_cast<int>(key.size());
// Ensure the size fits into an int before casting
if (key.size() > static_cast<std::size_t>((std::numeric_limits<int>::max)())) {
ec = error_category::load_key_bio_write; // Add an appropriate error here
return {};
}
int len = static_cast<int>(key.size());
if (BIO_write(pubkey_bio.get(), key.data(), len) != len) {
ec = error_category::load_key_bio_write;
return {};
Expand Down
Loading