Skip to content

fix: Incorrect Renamed event args on unix #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vbreuss merged 11 commits into from
Jan 21, 2026
Merged

fix: Incorrect Renamed event args on unix #919

vbreuss merged 11 commits into from
Jan 21, 2026
+1,395 −34

Conversation

@pw-sgr
Copy link
Contributor

@pw-sgr pw-sgr commented Jan 16, 2026

@pw-sgr
Copy link
Contributor Author

pw-sgr commented Jan 16, 2026

@vbreuss implemented the correct behaviors, tho one problem I have with windows are the Changed events, which fire almost randomly and not repreducable between Windows Server 2025 (github image) and my local Windows 11 Pro 24H2 26100.7462, so for now I ignored them

@pw-sgr
Copy link
Contributor Author

pw-sgr commented Jan 16, 2026

@stogle fyi

@pw-sgr
Copy link
Contributor Author

pw-sgr commented Jan 16, 2026

MacOs fails because the file watcher receives the arrange make dir, I'll take a look on monday

@pw-sgr
Copy link
Contributor Author

pw-sgr commented Jan 19, 2026

@vbreuss would be done with the fix

Regarding the Mac edge-case, were old events matching the filter will be invoked, it's reliable to get, but not exactly documented to simuate it, or I just haven't found it. Unfortunatly I do not own a Mac and cannot test/investigate that

vbreuss
vbreuss reviewed Jan 19, 2026
View reviewed changes
Copy link
Member

@vbreuss vbreuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't realize how many edge-cases we could/should consider. I'm impressed that you got it working (I already gave up on it 👍).

pw-sgr added 11 commits January 21, 2026 12:49
@pw-sgr
test: added tests for watching moving files
37a536a
@pw-sgr
fix: fixed FileSystemWatcherMock not raising the correct events when …
4fa2f41 
…moving files
@pw-sgr
test: correct item move tests for FileSystemWatcherMock
0ef080c
@pw-sgr
style: fixed code styling in FileSystemWatcherMock
268574e
@pw-sgr
test: improved FileSystemWatcherMock tests by checking the event prop…
662a828 
…erties and fixed for mac
@pw-sgr
test: fixed FileSystemWatcherMock tests for Mac
e79d456
@pw-sgr
test: fixed FileSystemWatcher.MoveTests.IsMac not being true for mac …
84e91bf 
…tests
@pw-sgr
test: fixed FileSystemWatcherMock tests expecting created events on e…
1f4ddd7 
…xcluded items
@pw-sgr
test: cleaned up FileSystemWatcherMock tests
da2149f
@pw-sgr
refactor: cleaned up FileSystemWatcherMock and replaced premise comme…
dc4b4d7 
…nts with Debug.Assert
@pw-sgr
test: cleaned up FileSystemWatcherMock.MoveTests
721c491
@pw-sgr pw-sgr force-pushed the issue-899-regression branch from 693e437 to 721c491 Compare January 21, 2026 11:49
@pw-sgr
Copy link
Contributor Author

pw-sgr commented Jan 21, 2026

now I remember why the IEquatable<T> in RenamedContext, was the Codacy Static Code Analysis

@vbreuss
Copy link
Member

vbreuss commented Jan 21, 2026

now I remember why the IEquatable<T> in RenamedContext, was the Codacy Static Code Analysis

I'm on it!

@vbreuss vbreuss merged commit 68305d1 into Testably:main Jan 21, 2026
11 checks passed
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

This is addressed in release v5.0.3.

@stogle stogle mentioned this pull request Jan 21, 2026
Closed
This was referenced Jan 22, 2026
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbreuss vbreuss vbreuss left review comments

Assignees

No one assigned

Labels

state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pw-sgr @vbreuss