Add PAGX module with spec, importer, exporter, SVG converter, and web playground#3278
Merged
Add PAGX module with spec, importer, exporter, SVG converter, and web playground#3278
Conversation
…l-canvas clip masks.
…ified samples layout.
…d_map iteration with stable vector-based traversal order.
…d apply aggressive B.4 optimization.
…eserve original design appearance.
… on non-overlapping elements.
…or rendering performance.
…to prepareForLoading.
…h ParsingContext as friend.
…rrorUI via setDropZoneState.
…icit conversions.
…hared text layout logic in Typesetter.
…which are already float type.
…rence and remove const_cast.
… like 0.0f across all public headers.
shlzxjp
reviewed
Feb 13, 2026
Comment on lines
+46
to
+55
| for (int y = 0; y < height; y += tileSize) { | ||
| bool draw = (y / tileSize) % 2 == 1; | ||
| for (int x = 0; x < width; x += tileSize) { | ||
| if (draw) { | ||
| recorder->addRect( | ||
| tgfx::Rect::MakeXYWH(static_cast<float>(x), static_cast<float>(y), | ||
| static_cast<float>(tileSize), static_cast<float>(tileSize)), | ||
| tilePaint); | ||
| } | ||
| draw = !draw; |
Collaborator
There was a problem hiding this comment.
第二个for循环可以每次 x += 2 * tileSize，循环可以节省一半
Hparty
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cmake -G Ninja -DPAG_BUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Debug -B cmake-build-debug && cmake --build cmake-build-debug --target PAGFullTestcompiles successfullyresources/apitest/SVG/spec/samples/render correctly in the playground