ANDROID-16934 -- (V) Remove databinding related code#483
Merged
dhonti-axpe merged 1 commit intoANDROID-16934/base-remove-databindingfrom Jan 19, 2026
Merged
Conversation
- Remove some old comments - Update forgotten "buttonOnClick" component necessary in attrs_components - Update correctly "LoadErrorFeedbackView" component
|
[Firebase] 📱 New catalog for testing generated: |
dhonti-axpe
requested review from
a team,
jeprubio and
jeslat
and removed request for
a team
jeprubio
approved these changes
Jan 19, 2026
jeslat
approved these changes
Jan 19, 2026
dhonti-axpe
merged commit 5b33b54
into
ANDROID-16934/base-remove-databinding
4 checks passed
dhonti-axpe
added a commit
that referenced
this pull request
Jan 20, 2026
* ANDROID-16934 -- (III) Remove databinding related code (#480) * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TextLink" component * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "ListRowView" and "MisticaRecyclerView" components and update the corresponding README file * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "DeterminateStepperView" and "IndetermianteStepperView" components * ANDROID-16934/pr3-remove-databinding: Remove databinding methods from "TitleView" component * ANDROID-16934/pr3-remove-databinding: Update correct word in README file * ANDROID-16934 -- (I) Remove databinding related code (#478) * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "button2/Button" component * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CalloutView" components and update corresponding README file * ANDROID-16934/pr1-remove-databinding: Remove databinding references from "CardView" components and update corresponding REDME file * ANDROID-16934/pr1-remove-databinding: Remove databinding references form "EmptyState" components and update corresponding README files * ANDROID-16934/pr1-remove-databinding: Revert some extra spaces * ANDROID-16934/pr1-remove-databinding: Remove some extra space from "DataCardView" * ANDROID-16934/pr1-remove-databinding: Revert some lint space changes * ANDROID-16934 -- (II) Remove databinding related code (#479) * ANDROID-16934/pr2-remove-databinding: Remove databinding method from "LoadErrorFeedabackView" component and update corresponding README file. * ANDROID-16934/pr2-remove-databinding: Update README file from "feedback/screen" component * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HeaderView" component and update corresponding README file * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "HighlightedCardView" component and update its corresponding README file. * ANDROID-16934/pr2-remove-databinding: Remove databinding methods from "Input", "TextInput" and expose some attributes also from "CheckBoxInput" components, updating their corresponding README files * ANDROID-16934/pr2-remove-databinding: Remove unused imports from "TextInput" component * ANDROID-16934/pr2-remove-databinding: Remove duplicate line * ANDROID-16934/pr2-remove-databinding: Fix grammar in README file * ANDROID-16934/pr4-remove-databinding: (#482) - Remove databinding feature and kapt (used by first one) - Replace implementation by "api" in "androidx.compose.ui" library * ANDROID-16934/pr5-remove-databinding: Update some rest components: (#483) - Remove some old comments - Update forgotten "buttonOnClick" component necessary in attrs_components - Update correctly "LoadErrorFeedbackView" component * ANDROID-16934/base-remove-databinding: Remove unused attribute from "button2/Button" component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-16934
🥅 What's the goal?
After applying following previous PRs:
Is fully remove DataBinding usage from the Mística library and align its Gradle configuration with the new Jetpack Compose–based architecture, ensuring proper dependency propagation to consumer projects (
android-messengerandSmartWifi).🚧 How do we do it?
In previous PRs about this main feature, was forgotten:
LoadErrorFeedbackViewcomponent.attrs_components.xmlthebuttonOnClickparameter inbutton2/Buttoncomponentdatabindingreferences.☑️ Checks
🧪 How can I test this?
As is mentioned in the corresponding ANDROID-16934 ticket, is tested in the "android-messenger" client project that the total PR changes exposed in #476 works correctly.