General improvements #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are general updates to improve the library, remove footguns and remove unneccesary libs.
STEAM_AUTH_HTTP_TIMEOUTwith a default value of15seconds to give better control around the outbound lifecycle for requests to Steam.url.Valuesand string methods, simplifying the logic and reducing potential bugs.httpDoerinterface and a globalhttpClientvariable, allowing for dependency injection and easier testing of HTTP interactions.ValidateResponse, including stricter checks on claimed identity and SteamID extraction.gosteamauth_test.gowith afakeHTTPClientto mock HTTP responses, providing thorough unit tests forValidateResponse, including success, failure, network error, timeout, and identity mismatch scenarios.