Ninas Project Labyrinth #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvaSjoholm
reviewed
May 4, 2023
EvaSjoholm
left a comment
EvaSjoholm
left a comment
There was a problem hiding this comment.
Really good work Nina and nice with the sound effect at the end, everything working as it should and loved your animation + background image.
All I could give as input is creating more folders to keep the design-code in separate files so it get's a bit cleaned up, styled components like you did use.
Great work, be proud!
| } | ||
|
|
||
| useEffect(() => { | ||
| const audio = new Audio(soundFile); // Create an Audio object with the sound file |
| } | ||
| }, [showEndPage]); | ||
|
|
||
| const ResetBtn = styled.button` |
There was a problem hiding this comment.
Maybe create a separate file for your design and styled components to keep function-files a bit cleaner/easy to follow :) But just an input, nothing major!
| export const Direction = ({ actions = [] }) => { | ||
| const dispatch = useDispatch(); | ||
|
|
||
| useEffect(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.