Skip to content

Fix sample time calculation for times >= 2^32. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enzo1982 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sample time calculation for times >= 2^32. #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mp4track.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ void MP4Track::GetSampleTimes(MP4SampleId sampleId,
}

for (uint32_t sttsIndex = m_cachedSttsIndex; sttsIndex < numStts; sttsIndex++) {
uint32_t sampleCount =
uint64_t sampleCount =
m_pSttsSampleCountProperty->GetValue(sttsIndex);
uint32_t sampleDelta =
m_pSttsSampleDeltaProperty->GetValue(sttsIndex);
Expand Down Expand Up @@ -1109,7 +1109,7 @@ MP4SampleId MP4Track::GetSampleIdFromTime(
MP4Duration elapsed = 0;

for (uint32_t sttsIndex = 0; sttsIndex < numStts; sttsIndex++) {
uint32_t sampleCount =
uint64_t sampleCount =
m_pSttsSampleCountProperty->GetValue(sttsIndex);
uint32_t sampleDelta =
m_pSttsSampleDeltaProperty->GetValue(sttsIndex);
Expand Down