fix: fix null-check logic method call error#635
Conversation
prpr/src/parse/rpe.rs
Outdated
| .extended | ||
| .as_ref() | ||
| .is_none_or(|it| it.text_events.as_ref().is_some_and(|it| it.is_empty())) | ||
| .map_or(true, |it| it.text_events.as_ref().map_or(true, |it| it.is_empty())) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Extra Info for this PRChart ID: Pause Button made by Drag Note Scaling White Block Scaling (Before COMBO 0 or After COMBO 825 or After COMBO 1065+ == near the END) Weird Yellow Block in right-bottom corner (After COMBO 1065+ == near the END) About Review RequestTL;DR, Yeah, it matches what I mentioned in my review. Just have a TeamFlos member review it. I don't believe I'm capable of conducting a formal review/approve. I tried to mark my requested changes as resolved but GitHub don't let me do due to permission. First, I can't create a valid approving review to let this PR able to merge, which requires the user have The mistake is weird because this won't happen after |



In the current mainline version, the pause button displays abnormally (e.g., for ID=16624), and there are rendering glitches in the latter half of the chart. I reverted to the previous code, and it works fine