-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: React Helmet Async 마이그레이션 및 SEO 적용 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- index.html: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/pages/ScrapFlow.jsx:38
- [nitpick] Ensure that the 'fetchData' function is memoized or stable, as including it in the dependency array may trigger unnecessary re-renders if it changes on every render.
}, [currentPage, fetchData]);
src/pages/RecreationDetail.jsx:59
- The description concatenates an array with a string, which may not yield the intended format; consider joining the array using a separator (e.g., .join(', ')) before concatenation.
description={recreationData.purposeList.map((purpose) => PURPOSE[purpose].value) + recreationData.summary}
vite.config.ts
Outdated
| }, | ||
| postProcess(renderedRoute) { | ||
| renderedRoute.html = renderedRoute.html | ||
| .replace(/http:/i, 'https:') |
Copilot
AI
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If multiple 'http:' occurrences may be present in the HTML, consider using a global flag (e.g., /http:/gi) to ensure all occurrences are replaced.
| .replace(/http:/i, 'https:') | |
| .replace(/http:/gi, 'https:') |
src/pages/RecreationDetail.jsx
Outdated
| recreationData.purposeList.map((purpose) => PURPOSE[purpose].value) + | ||
| recreationData.summary | ||
| } | ||
| keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value)} |
Copilot
AI
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'keywords' prop expects a string but an array is provided; consider joining the array into a comma-separated string using .join(', ') to meet the prop type requirements.
| keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value)} | |
| keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value).join(', ')} |
📢 기능 설명
PageMetadata공통 컴포넌트 제작🔗 연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #155
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트