Skip to content

Conversation

@eomgerm
Copy link
Contributor

@eomgerm eomgerm commented Apr 10, 2025

📢 기능 설명

  • React Helmet -> React Helmet Async
  • Puppeteer + Prerender 일부 적용
  • PageMetadata 공통 컴포넌트 제작

🔗 연결된 issue

연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.

close #155


🩷 Approve 하기 전 확인해주세요!

  • 리뷰어가 확인해줬으면 하는 사항 적어주세요.

✅ 체크리스트

  • PR 제목 규칙 잘 지켰는가?
  • 추가/수정사항을 설명하였는가?
  • 이슈넘버를 적었는가?
  • Approve 하기 전 확인 사항 체크했는가?

@eomgerm eomgerm added the enhancement New feature or request label Apr 10, 2025
@eomgerm eomgerm requested a review from Copilot April 10, 2025 11:43
@eomgerm eomgerm self-assigned this Apr 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • index.html: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/pages/ScrapFlow.jsx:38

  • [nitpick] Ensure that the 'fetchData' function is memoized or stable, as including it in the dependency array may trigger unnecessary re-renders if it changes on every render.
  }, [currentPage, fetchData]);

src/pages/RecreationDetail.jsx:59

  • The description concatenates an array with a string, which may not yield the intended format; consider joining the array using a separator (e.g., .join(', ')) before concatenation.
        description={recreationData.purposeList.map((purpose) => PURPOSE[purpose].value) + recreationData.summary}

vite.config.ts Outdated
},
postProcess(renderedRoute) {
renderedRoute.html = renderedRoute.html
.replace(/http:/i, 'https:')
Copy link

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If multiple 'http:' occurrences may be present in the HTML, consider using a global flag (e.g., /http:/gi) to ensure all occurrences are replaced.

Suggested change
.replace(/http:/i, 'https:')
.replace(/http:/gi, 'https:')

Copilot uses AI. Check for mistakes.
recreationData.purposeList.map((purpose) => PURPOSE[purpose].value) +
recreationData.summary
}
keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value)}
Copy link

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'keywords' prop expects a string but an array is provided; consider joining the array into a comma-separated string using .join(', ') to meet the prop type requirements.

Suggested change
keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value)}
keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value).join(', ')}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] SEO 최적화

1 participant