Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a monthly expense retrieval API for receipts by introducing a new domain model (DetailExpenseResult) and corresponding service, DTO, and API endpoint changes.
- Adds a new method in ReceiptEditor to calculate monthly expenses.
- Introduces DetailExpenseResult and ReceiptExpenseResponse to encapsulate monthly expense data.
- Updates service, use case, and controller layers to support the new API endpoint.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ReceiptEditor.java | Adds calculateExpense with monthly grouping of receipts. |
| DetailExpenseResult.java | Introduces the domain model for representing monthly expense results. |
| FindReceiptService.java | Implements the service method mapping expense data to response DTOs. |
| FindReceiptUseCase.java | Extends the use case interface with expense list retrieval. |
| ReceiptExpenseResponse.java | Creates a new DTO for monthly expense data with a builder-based factory method. |
| FindReceiptApi.java | Defines the API endpoint for querying monthly expense data. |
| FindReceiptController.java | Exposes a new GET endpoint to retrieve monthly expense information. |
Comments suppressed due to low confidence (1)
src/main/java/com/ClubAccount_BE/receipt/domain/service/ReceiptEditor.java:54
- [nitpick] Consider renaming 'calculateExpense' to 'calculateMonthlyExpense' to better reflect the operation performed.
public List<DetailExpenseResult> calculateExpense(List<Receipt> receiptList, int year) {
...main/java/com/ClubAccount_BE/receipt/adapter/in/web/dto/response/ReceiptExpenseResponse.java
Show resolved
Hide resolved
|
tiemo0708
reviewed
May 14, 2025
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📌 작업 개요
✅ 작업 내용
DetailExpenseResult반환📂 리뷰 요구사항