Conversation
sese2204
requested review from
hyobin-yang,
seungwon7934,
win9-tech and
yoonjiseok
sese2204
commented
Feb 19, 2025
| super(baseErrorCode); | ||
| public DuplicateResourceException(ErrorStatus errorStatus) { | ||
| super(errorStatus); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
BaseErrorCode 추상화 로직 다 ErrorStatus로 바꿨던데 이유가 뭔가요?
지금 구현이면 BaseErrorCode 삭제해도 될 것 같습니다.
sese2204
commented
Feb 19, 2025
| } catch (JwtException e) { | ||
| // 유효하지 않은 리프레시 토큰 | ||
| throw new GeneralException(ErrorStatus.TOKEN_INVALID); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
제가 구현하여 사용한 InvalidRefreshTokenException을 GeneralException으로 수정하신 이유가 뭔가요?
win9-tech
force-pushed
the
refactor/#146
branch
from
c734f1d to
1f1a1e6
Compare
win9-tech
force-pushed
the
refactor/#146
branch
from
1f1a1e6 to
82f9544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용