Open
Conversation
|
Hey Weston, Great job dude! I'm really impressed. You got the random import down, I love the static "fight" method, you have type casting--great stuff. Some of it wasn't covered in class, so whatever research you did is great. Even if AI suggested that that's how you do it, so long as you understand it then that's totally fine. Few small things to note though
Whether or not you actually fix those last two things is completely up to you, but please do lmk where I can find the check for understanding. I could just be blind, but in the alternative of you having not done it yet, just do it and send it over when you can. Great work! |
…p of the pokemon child classes, made all the instance variables in the parent pokemon class private
|
Perfect, love to see it. You're explanations are fantastic, I'm exctied to see you try out robot training next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry Noah, I totally forgot the check for understanding ¯\_(ツ)_/¯. I also followed your instructions to put the constructers at the top of each subclass, and made all my instance variables in the pokemon class private and therefore I had to make a whole host of getters and setters for each variable. Thank you so much for the feedback.