Conversation
Closed
thinkySide
commented
Apr 30, 2025
|
|
||
| struct CommentView: View { | ||
| @Bindable var store: StoreOf<CommentFeature> | ||
| struct BoardCommentView: View { |
Contributor
Author
There was a problem hiding this comment.
답변 댓글도 생긴만큼 게시판 댓글 리스트도 명확히 구분해주기 위해 네이밍을 업데이트했습니다.
thinkySide
commented
Apr 30, 2025
| store.send(.academyDayCounterTapped) | ||
| } label: { | ||
| QPAcademyDayCounter() | ||
| QPAcademyDayCounter(event: store.event) |
Contributor
Author
There was a problem hiding this comment.
아카데미 일정 카운터 컴포넌트에 event 속성을 주입받을 수 있도록 업데이트했습니다.
onAppear, refresh, active 등에 대응하기 위해선 Reducer가 이벤트 속성을 가지고 있어야 하기 때문에 수정해주었습니다!
thinkySide
commented
Apr 30, 2025
Comment on lines
+27
to
+31
| .onChange(of: scenePhase) { _, newPhase in | ||
| if newPhase == .active { | ||
| store.send(.active) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
ScenePhase 환경 변수를 이용해 앱에 재진입 시 자연스럽게 리프레쉬 할 수 있도록 구현했습니다. 오늘의 질문 쪽도 똑같아요!
OhMyungJin
approved these changes
May 5, 2025
Contributor
OhMyungJin
left a comment
OhMyungJin
left a comment
There was a problem hiding this comment.
LGTM!!
scenePhase 기능 완전 좋네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #364
TO-DO
상세 설명
스크린샷