Skip to content

ids param for currencies.get_sparkline #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LogicallyUnfit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ids param for currencies.get_sparkline #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions nomics/api/currencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,20 @@ def get_metadata(self, ids = None, attributes = None):
else:
return resp.text

def get_sparkline(self, start, end = None):
def get_sparkline(self, start, ids = None, end = None):
'''
Returns prices for all currencies within a customizable time interval suitable for sparkline charts.

:param str start: Start time of the interval in RFC3339 format

:param str end: End time of the interval in RFC3339 format. If not provided, the current time is used.
:param str ids: Comma separated list of Nomics Currency IDs to filter result rows. Optional

:param str end: End time of the interval in RFC3339 format. If not provided, the current time is used.
'''

url = self.client.get_url('currencies/sparkline')
params = {
'ids': ids,
'start': start,
'end': end
}
Expand Down