Show users any errors in Stripe token creation#10
Open
staringispolite wants to merge 6 commits intoTaylorBriggs:masterfrom
Open
Show users any errors in Stripe token creation#10staringispolite wants to merge 6 commits intoTaylorBriggs:masterfrom
staringispolite wants to merge 6 commits intoTaylorBriggs:masterfrom
Conversation
TaylorBriggs
requested changes
Nov 7, 2017
| // context.fail(err); | ||
| //} else { | ||
| // context.succeed({ status: charge.status, success : true }); | ||
| //} |
Owner
There was a problem hiding this comment.
I wouldn't be able to pull these changes in with this PR; they appear to be specific to your use case.
Author
There was a problem hiding this comment.
Oh, ugh. I keep forgetting that PRs aren't frozen in time, so you can't continue to push to your own branch. Can you pull in only that first commit? Or do I need to re-fork and make another?
Owner
There was a problem hiding this comment.
You would need to make a new PR with just the one commit that adds the error logging.
| },function(err, token){ | ||
| if (err) { | ||
| grunt.log.writeln(err); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.