Merged
Conversation
767faea to
9428982
Compare
obrie
reviewed
Aug 20, 2025
Member
obrie
left a comment
There was a problem hiding this comment.
Before I review further, can you expand in the PR description with some examples of what we're trying to support? There are some interface changes being made here and it's not clear to me why they're needed.
87b2efd to
850df19
Compare
9428982 to
a119381
Compare
a119381 to
f4efdf5
Compare
obrie
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PayloadHandlerand makes it configurable so users can build custom payload handling for additional meta data or third party messaging consumption.Chore is built upon the assumption that messages published to the queue will be handled by Chore. Even though Chore allows for configuration of
payload_handler, it assumes a structure of the message that makes it difficult to do processing of messages that's not published by Chore (ie. third party streaming data). For instance, it assumes thisjob_hash:This makes it difficult to parse if the message does not correspond to this structure, for instance:
Chore determines the process to run by constantizing the class in the message which poses problems for messages published without this data.
In order to facilitate the above, the method signature for decoding the message was updated to take the
UnitOfWorkwith quite a bit of data. It also refactors code a bit to place message structure handling intoPayloadHandlerrather thanJobto cleanly separate concerns. This way, a user has control over how messages should be constructed/deconstructed. The code still breaks if you don't follow the originaljob_hash, but it allows for great flexibility on the decoding of the message without reworking a ton of Chore internals. A custom payload handler may look like this.