Skip to content

Conversation

@olekspickle
Copy link

@olekspickle olekspickle commented Dec 21, 2025

Wanted to try out your awesome plugin, but it breaks builds for people who do not use default (f.e. using bevy_seedling instead of bevy_audio)

This narrows features so that it is usable for someone who does not rely on default features, tested a few examples, it worked I guess, however day shader was a bit crazy bright :D

@TanTanDev
Copy link
Owner

Nice catch.
I see you swapped out bevy version from "0.17" to "0.17.3".
I'm unsure what the best practice is for libraries when it comes to version selection.
I set it to "0.17" so we can support all minor bevy versions. (I don't know why someone would use lower versions... but maybe it's a good idea to support that..?).
Can someone give some insight as to the best practice when it comes to versioning.

@olekspickle
Copy link
Author

olekspickle commented Dec 23, 2025

Hmm, I also use 0.17 in my binary project, my logic was that for libraries it's generally better to be as specific as possible, I guess I can change it back to 0.17 if you'd want to just offload it to the user

Also would you want it to be 0.17 or ^0.17?

@weihnaxbaum
Copy link

Also would you want it to be 0.17 or ^0.17?

That is the same. If you meant =0.17 or 0.17, the latter is the better choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants