[TASK] Migrate composer normalize command to runTests.sh
#1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19829009522Details
💛 - Coveralls |
kanow
force-pushed
the
1751-migrate-composer-normalize
branch
from
5ab44ed to
8fe0305
Compare
kanow
force-pushed
the
1751-migrate-composer-normalize
branch
from
8fe0305 to
c504718
Compare
kanow
changed the title
Contributor
Author
|
Split normalize command in two. One check and one fix. |
One for check and one for fix Related: #1751
kanow
force-pushed
the
1751-migrate-composer-normalize
branch
from
74952de to
603deeb
Compare
oliverklee
reviewed
Dec 1, 2025
| command: | ||
| - "phpmd" | ||
| - "checkComposerNormalize" | ||
| - "fixComposerNormalize" |
Contributor
There was a problem hiding this comment.
I think that only checkComposerNormalize belongs into the static-code-analysis job (and that it warrants its own entry in the test matrix).
Still, I think it would be worthwhile to also check in CI that our fix scripts can at least be run without errors. I propose we add a separate job checkFixers that will run all existing fixers one after another, with fixComposerNormalize as a start as part of this PR. What do you think?
Contributor
Author
There was a problem hiding this comment.
checkFixers? Nice idea. This should be done in another issue I think, right?
For this PR I remove the checkComposerNormalize command.
oliverklee
changed the title
runTests.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1751