Skip to content

Comments

Tests cases specification#120

Closed
pietercolpaert wants to merge 20 commits intomasterfrom
feat-tests
Closed

Tests cases specification#120
pietercolpaert wants to merge 20 commits intomasterfrom
feat-tests

Conversation

@pietercolpaert
Copy link
Member

@pietercolpaert pietercolpaert commented Feb 17, 2025 •
edited
Loading

Working on a proposal to add tests cases in the spec for #97

@pietercolpaert pietercolpaert mentioned this pull request Feb 17, 2025
Open
smessie
smessie reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@smessie smessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving some thoughts here while going through the current draft.

pietercolpaert and others added 4 commits March 31, 2025 12:24
@pietercolpaert @smessie
Update 04-tests.bs
8c2e50b 
Co-authored-by: Ieben Smessaert <smessie@users.noreply.github.com>
@pietercolpaert @smessie
Update 04-tests.bs
cb1c0f5 
Co-authored-by: Ieben Smessaert <smessie@users.noreply.github.com>
@pietercolpaert @smessie
Apply suggestions from code review
d8919af 
Co-authored-by: Ieben Smessaert <smessie@users.noreply.github.com>
@pietercolpaert
Further tests based on code review
8f7835f
xdxxxdx
xdxxxdx reviewed Apr 2, 2025
View reviewed changes
04-tests.bs Outdated

This test is about a function `initialization(url)`. The function will return the URL of the collection and the URL of the root node.

We will test this with various URLs containing different contents.
Copy link
Collaborator

@xdxxxdx xdxxxdx Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to explain the purpose of the TREE test specification (perhaps in an overview section). For example (correct me if I am wrong):

The TREE test specification aims to provide a set of tests for validating that a tree client implementation conforms to the TREE specification. The TREE implementors can use this conforming client to interact with data sources to validate TREE conformity.

Additionally, it might be clearer (to people like me XD) to explain what the initialization function does. For example:

The initialization(url) function returns the URL of the collection and the URL of the root node.

The following test scenarios describe how the initialization(url) function of the tree client should behave in various situations involving the TREE and the parameter URL.

@xdxxxdx xdxxxdx mentioned this pull request May 22, 2025
Open
@xdxxxdx
feat: update test specification
5a5af5f 
- Restructured the documentation to create a narrative.
- Addressed my concern regarding the comment left in [issue #141](#141), questioning whether this specification is ONLY focused on client behavior.
- OFC, a work in progress
@xdxxxdx
Copy link
Collaborator

xdxxxdx commented May 22, 2025

Hi @pietercolpaert,
Just to let you know, I don't have write access to this branch. I've created another PR #142 to continue making progress. (it is fine, I'll proceed this way.)

@pietercolpaert
Merge pull request #142 from xdxxxdx/feat-tests
36a6755 
feat: update test specification
@pietercolpaert
Copy link
Member Author

pietercolpaert commented Jun 5, 2025

Hi @pietercolpaert, Just to let you know, I don't have write access to this branch. I've created another PR #142 to continue making progress. (it is fine, I'll proceed this way.)

I now made sure you have write access as well!

@xdxxxdx
Copy link
Collaborator

xdxxxdx commented Jun 11, 2025 •
edited
Loading

rorlic/tree-shacl#1

  • I envision that the spec tests can only test a tree:Node (basic elements of the Tree), or a part of the full tree graph, therefore I made these two categories in the conformance points.
  • The tests, in my view, need to emphasize the minimum requirements of a TREE implementation (the content of the TREE).
  • I included the generated HTML(and will remove the HTML once the PR is settled) in the PR as well. Please feel free to comment on the current version. I would like to collect feedback on the current format.

xdxxxdx and others added 9 commits June 19, 2025 16:37
@xdxxxdx
Update 04-tests.bs
6d213be
@xdxxxdx
Update 04-tests.bs
4b3b299
@xdxxxdx
Update 04-tests.bs
b3b47fb
@xdxxxdx
feat: add test spec
60cc303 
- I envision that the spec tests can only test a tree:Node (basic elements of the Tree), or a part of the full tree graph, therefore I made these two categories in the conformance points.
- The tests, in my view, need to emphasize the minimum requirements of a TREE implementation (the content of the TREE).
- I included the generated HTML in the PR as well. Please feel free to comment on the current version. I would like to collect feedback on the current format and will remove the HTML once the PR is settled.
@xdxxxdx
Update 04-tests.bs
2f23d7d
@xdxxxdx
feat: delete redundancy
ade9082
@xdxxxdx
Update 04-tests.bs
70b9c85
@xdxxxdx
Merge pull request #153 from TREEcg/master
078d212 
fix; merge the update of the main branch
@xdxxxdx
Delete 04-tests.html
d04b2e4
@pietercolpaert
Copy link
Member Author

pietercolpaert commented Dec 18, 2025

Instead we’re going for #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xdxxxdx xdxxxdx xdxxxdx left review comments

+1 more reviewer

@smessie smessie smessie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pietercolpaert @xdxxxdx @smessie