Lit rewrite #97
Open
Lit rewrite #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MattiasBuelens
force-pushed
the
lit
branch
2 times, most recently
from
fcdae9d to
09cd407
Compare
Contributor
|
Can we also include adding the settings menu to the default ui? 😄 |
Collaborator
Author
|
@GillesMoris-Dolby That's in 8a4ac0f. But yes, I still need to write up the changelog... |
MattiasBuelens
force-pushed
the
lit
branch
2 times, most recently
from
1ac190c to
3f678dd
Compare
🦋 Changeset detectedLatest commit: b129307 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MattiasBuelens
force-pushed
the
lit
branch
11 times, most recently
from
b3414e0 to
780dcb9
Compare
MattiasBuelens
force-pushed
the
lit
branch
3 times, most recently
from
547fc6e to
743b504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor all components to extend
LitElementfrom Lit. This makes it much easier to change the rendered shadow DOM (using arender()method instead of manually manipulating DOM notes) and to link attributes to properties. It also opens up the way for features like localization.The public API of all components remains identical, so customers shouldn't notice if they're just using the default UI or building a custom UI using our built-in components. I've also taken care to preserve the ability to pass a
<template>element to theButtonandMenuconstructors for custom components that want to subclass those classes, however that ability is now deprecated.For UMD and ES5 builds, the Lit library is bundled together with Open Video UI. For modern ESM builds, we don't bundle Lit, instead relying on the end user's bundler to do so. This is a potentially breaking change, so we should release this as 2.0.0.
We now also ship our own polyfill bundle (
@theoplayer/web-ui/polyfills), to make it easier for customers to install the right set of polyfills on older browsers. This should also make it easier to add extra polyfills in the future, should the need arise.To do: