Split DCR/DTVR implementations #82
Conversation
- inconvenient to maintain a single multipurpose codebase - some configuration/signature breaking changes
🦋 Changeset detectedLatest commit: 9071e1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| configuration?: NielsenConfiguration | ||
| ) { | ||
| this.nielsenHandler = new NielsenHandler(player, appId, instanceName, options, configuration); | ||
| if (configuration?.country === NielsenCountry.US) { |
There was a problem hiding this comment.
Previously DTVR was the default value but now it changed to DCR. Probably should keep the default to DTVR.
| * Returns an appropriate handler specified in the configuration. | ||
| * | ||
| */ | ||
| export function getNielsenHandler( |
There was a problem hiding this comment.
This function is not used
|
|
||
| Split DCR/DTVR implementations | ||
|
|
||
| - inconvenient to maintain a single multipurpose codebase |
There was a problem hiding this comment.
These entries should not be part of our changelog as it does not change the behavior of the connector.
Instead I'd mention that they are split indeed and the changes to the configuration object as well as removing updateDCRContentMetadata in favour of the general updateMetadata.
There was a problem hiding this comment.
Thinking about it again, maybe it would be better if we could deprecate the updateDCRContentMetadata and enableDCR/enableDTVR instead of removing them already. Then we can give everyone some time to update to the new way. @wjoosen thoughts?
2 participants
Rundown of changes: