Feature/conviva/bump conviva sdk #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therama
reviewed
Dec 15, 2025
THEOplayer-Connector-Conviva.podspec
Outdated
| s.subspec 'Base' do |base| | ||
| base.source_files = 'Code/Conviva/Source/Base/**/*' | ||
| base.dependency 'ConvivaSDK', '4.0.51' | ||
| base.dependency 'ConvivaSDK', '~> 4.0' |
Contributor
There was a problem hiding this comment.
We can either do this way, or go the subspec route where we add a new 'Dependencies' subspec that will include 'ConvivaSDK', '4.0.51', and is part of the default_subspecs list on line 37. Then the Podfile can opt out of the dependency.
Contributor
Author
There was a problem hiding this comment.
By putting this to ~> 4.0 a customer can still specify or lock to a preferred version, as long as it's 4.0 or higher. So same goal achieved, but less hassle?
Contributor
Author
There was a problem hiding this comment.
As discussed, now locking to a more recent version, on request by customer.
Contributor
There was a problem hiding this comment.
we will fix the validation code in a follow-up PR
wvanhaevre
force-pushed
the
feature/conviva/bump-conviva-sdk
branch
from
dc713a2 to
e3ba7be
Compare
wvanhaevre
force-pushed
the
feature/conviva/bump-conviva-sdk
branch
from
e3ba7be to
17b11c9
Compare
Danesz
approved these changes
Dec 17, 2025
therama
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.