Bugfix/sideloaded subtitles invalid url #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...eloaded-TextTracks/Sources/THEOplayerConnectorSideloadedSubtitle/Utils/SourceValidator.swift
Show resolved
Hide resolved
Contributor
|
@therama While we're touching this connector, how much effort is it to move it to the new network api away from the old manifestInterceptor? |
ceyhun-o
approved these changes
Dec 4, 2025
Contributor
Author
Was working on it. Here is the PR: https://github.com/THEOplayer/iOS-Connector/pull/101/files |
GillesMoris-Dolby
approved these changes
Dec 16, 2025
THEObuildbot
force-pushed
the
bugfix/sideloaded-subtitles-invalid-url
branch
from
9303371 to
27b80d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.