Conversation
wotjs020708
requested review from
soseoyo12,
sum130 and
y-eonee
and removed request for
a team
📝 WalkthroughWalkthrough치료 필터 뷰의 동적 간격 조정. 선택된 치료 항목이 없을 때와 있을 때를 구분하여 스페이서 높이를 조건부로 설정하는 레이아웃 수정입니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/Calendar/Treatment/View/NoTreatment/NoTreatmentFilterView.swift`:
- Around line 53-56: The frame height calculation applies the adjustedH scale
twice to scrollViewHeight causing excessive spacing; update the height
expression in the .frame call that uses viewModel.selectedTreatments and
scrollViewHeight so that scrollViewHeight is only scaled once (remove the extra
.adjustedH) and keep adjustedH applied to either scrollViewHeight or the added
constant (24) consistently to avoid double-scaling.
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/Calendar/Treatment/View/Treatment/TreatmentFilterView.swift`:
- Around line 78-81: The frame height applies .adjustedH twice to
scrollViewHeight; in the TreatmentFilterView replace the double-adjustment by
using scrollViewHeight directly (leave .adjustedH only on the empty case).
Update the .frame(height:) expression that references
viewModel.selectedTreatments and scrollViewHeight so it uses scrollViewHeight
(no .adjustedH) when not empty, keeping the existing 24.adjustedH on the empty
branch.
Comment on lines
+53
to
+56
| .frame( | ||
| height: viewModel.selectedTreatments.isEmpty ? | ||
| 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH | ||
| ) |
There was a problem hiding this comment.
scrollViewHeight 이중 스케일링으로 여백이 과해질 수 있습니다.
Line 53-56에서 scrollViewHeight 계산에 이미 adjustedH가 포함되어 있는데 다시 .adjustedH를 적용해 크기가 과장될 가능성이 있습니다. 동일하게 한 번만 적용해주세요.
🛠️ 수정 제안
- .frame(
- height: viewModel.selectedTreatments.isEmpty ?
- 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH
- )
+ .frame(
+ height: viewModel.selectedTreatments.isEmpty ?
+ 24.adjustedH : scrollViewHeight + 24.adjustedH
+ )📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .frame( | |
| height: viewModel.selectedTreatments.isEmpty ? | |
| 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH | |
| ) | |
| .frame( | |
| height: viewModel.selectedTreatments.isEmpty ? | |
| 24.adjustedH : scrollViewHeight + 24.adjustedH | |
| ) |
🤖 Prompt for AI Agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/Calendar/Treatment/View/NoTreatment/NoTreatmentFilterView.swift`
around lines 53 - 56, The frame height calculation applies the adjustedH scale
twice to scrollViewHeight causing excessive spacing; update the height
expression in the .frame call that uses viewModel.selectedTreatments and
scrollViewHeight so that scrollViewHeight is only scaled once (remove the extra
.adjustedH) and keep adjustedH applied to either scrollViewHeight or the added
constant (24) consistently to avoid double-scaling.
Comment on lines
+78
to
+81
| .frame( | ||
| height: viewModel.selectedTreatments.isEmpty ? | ||
| 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH | ||
| ) |
There was a problem hiding this comment.
scrollViewHeight에 .adjustedH가 중복 적용됩니다.
Line 78-81에서 scrollViewHeight는 이미 adjustedH를 포함해 계산되므로 다시 .adjustedH를 적용하면 기기별로 간격이 과도하게 늘어날 수 있습니다. scrollViewHeight는 그대로 사용하세요.
🛠️ 수정 제안
- .frame(
- height: viewModel.selectedTreatments.isEmpty ?
- 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH
- )
+ .frame(
+ height: viewModel.selectedTreatments.isEmpty ?
+ 24.adjustedH : scrollViewHeight + 24.adjustedH
+ )📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .frame( | |
| height: viewModel.selectedTreatments.isEmpty ? | |
| 24.adjustedH : scrollViewHeight.adjustedH + 24.adjustedH | |
| ) | |
| .frame( | |
| height: viewModel.selectedTreatments.isEmpty ? | |
| 24.adjustedH : scrollViewHeight + 24.adjustedH | |
| ) |
🤖 Prompt for AI Agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/Calendar/Treatment/View/Treatment/TreatmentFilterView.swift`
around lines 78 - 81, The frame height applies .adjustedH twice to
scrollViewHeight; in the TreatmentFilterView replace the double-adjustment by
using scrollViewHeight directly (leave .adjustedH only on the empty case).
Update the .frame(height:) expression that references
viewModel.selectedTreatments and scrollViewHeight so it uses scrollViewHeight
(no .adjustedH) when not empty, keeping the existing 24.adjustedH on the empty
branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용