Merged
Conversation
📝 WalkthroughWalkthrough챌린지 추천 AI 프롬프트를 2030세대 대상 에디토리얼 톤으로 대폭 재작성하고, OpenAI 모델을 gpt-5.1로 변경하며 토큰 설정 키를 Changes
Sequence Diagram(s)(생략 — 변경이 주로 프롬프트 및 설정 텍스트이며 다중 컴포넌트 제어 흐름 변경 사항이 아님) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In
`@src/main/java/com/sopt/cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java`:
- Around line 21-33: The prompt text in ChallengePromptTemplate.java contains a
contradiction between the rule "외래어·영어·전문용어는 일반적인 한국어 표현으로 치환" and the
recommended words/examples (e.g., "괄사", "림프", "PDRN", "토너", "마스크팩"); update the
template so the rule and examples are consistent by either (A) relaxing the rule
to explicitly allow a whitelist of common loanwords/industry terms (list those
allowed terms in the template) or (B) converting all example/recommended terms
to their Korean equivalents and removing loanwords (e.g., 괄사→괄사 설명 or
alternative Korean phrase, 림프→림프 순환 설명, PDRN→재생성분(또는 한국어 대체어), 토너→스킨/토너(표준화 뒤
하나로 통일), 마스크팩→마스크 시트 등); modify the constant(s) or string(s) in
ChallengePromptTemplate (look for the prompt template text block and the
sections around the “외래어·영어·전문용어” rule and the examples at lines ~49-53) to
reflect the chosen approach so the rule and examples no longer conflict.
- Around line 41-53: In ChallengePromptTemplate.java update the example phrases
so they all end with "하기" (or remove noncompliant examples) to match the rule
"모든 루틴 문장은 반드시 '~하기' 형태로 끝납니다"; locate the example block inside the prompt
template (ChallengePromptTemplate) and change items like "기상 직후 스트레칭 10분" -> "기상
직후 스트레칭 10분하기", "기상 직후 아침 명상" -> "기상 직후 아침 명상하기", and any other examples not
ending with "하기" (or remove them) so every example strictly follows the "~하기"
ending.
In `@src/main/resources/application-openai.yaml`:
- Around line 7-9: Replace the incorrect Spring AI property prefix so the
max-completion-tokens option binds correctly: change the current properties
under the keys model, temperature, and max-completion-tokens which are using the
prefix spring.ai.openai.chat.options (or plain spring.ai.openai.*) to use
spring.ai.openai-sdk.chat.options.max-completion-tokens (i.e., move
max-completion-tokens under spring.ai.openai-sdk.chat.options) while keeping
model and temperature under the corresponding spring.ai.openai-sdk.chat.*
grouping so the OpenAI options (e.g., gpt-5.1, temperature) bind correctly.
.../cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java
Show resolved
Hide resolved
.../cherrish/domain/challenge/recommendation/infrastructure/prompt/ChallengePromptTemplate.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Related issue 🛠
✏️ Work Description ✏️
📸 Screenshot 📸
😅 Uncompleted Tasks 😅
📢 To Reviewers 📢