マルチバイトユーザ名で地図が表示されない問題 #282
Conversation
WalkthroughC++ラッパーで Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Runner as GitHub Runner (macOS)
participant GetCMake as lukka/get-cmake Action
participant Shell as Shell
Note over Runner,GetCMake: macOS CIの追加ステップ
Runner->>GetCMake: install CMake (3.27.x)
GetCMake-->>Runner: CMake installed
Runner->>Shell: run `cmake --version`
Shell-->>Runner: version output (validated)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/actions/build/action.yml (1)
92-105: .github/actions/build/action.yml の -DCMAKE_POLICY_VERSION_MINIMUM=3.5 を削除
このオプションは CMake の既知オプションではなく no-op（キャッシュ変数にすぎません）。ポリシー固定は CMakeLists.txt 側でcmake_minimum_required(VERSION 3.8)／cmake_policy(SET CMP0076 NEW)などを使うか、CLI で-DCMAKE_POLICY_DEFAULT_CMP0077=NEW等で設定し、Unity と Unreal 両構成で整合を取ってください。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/build/action.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-and-test (windows-2022, x86_64)
- GitHub Check: check-submodule-license
- GitHub Check: build-and-test (ubuntu-24.04, x86_64)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/build/action.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build-and-test (ubuntu-24.04, x86_64)
- GitHub Check: check-submodule-license
- GitHub Check: build-and-test (macos-14, arm64)
- GitHub Check: build-and-test (windows-2022, x86_64)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/build/action.yml(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build and Test
.github/actions/build/action.yml
[error] 48-48: Unexpected value 'shell' in action.yml. Syntax error in GitHub Action definition.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check-submodule-license
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/upload-mobile-dlls/action.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: upload-dlls (ubuntu-24.04, x86_64)
- GitHub Check: upload-dlls (macos-14, x86_64)
- GitHub Check: upload-dlls (macos-14, arm64)
- GitHub Check: upload-dlls (windows-2022, x86_64)
- GitHub Check: upload_mobile_dlls (macos-14, 33, 30.0.3, 23.1.7779620)
- GitHub Check: upload_mobile_dlls (ubuntu-latest, 33, 30.0.3, 23.1.7779620)
- GitHub Check: build-and-test (windows-2022, x86_64)
- GitHub Check: build-and-test (macos-14, arm64)
- GitHub Check: build-and-test (ubuntu-24.04, x86_64)
- GitHub Check: check-submodule-license
🔗 関連リンク
https://synesthesias.atlassian.net/browse/CPSDK25-233
✅ レビュー前確認項目
✅ マージ前確認項目
🚀 実装内容
マルチバイト対応
path.string() => path.u8string()に変更。
🌐 影響範囲
C++ラッパー
🛠️ 動作確認
日本語ユーザ名のWindowsアカウントを使用して地図選択画面を開いた際に地図が表示されること（エラーがでないこと）
Summary by CodeRabbit
バグ修正
雑務