Use ECP sendData API in CleverDeal operations page#29
Open
ZimmySymphony wants to merge 1 commit intoSymphonyPlatformSolutions:masterfrom
Open
Use ECP sendData API in CleverDeal operations page#29ZimmySymphony wants to merge 1 commit intoSymphonyPlatformSolutions:masterfrom
ZimmySymphony wants to merge 1 commit intoSymphonyPlatformSolutions:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZimmySymphony
commented
Dec 5, 2023
| export const TradeExceptionDashboard = ( | ||
| props: TradeExceptionDashboardProps | ||
| ) => { | ||
| const { ecpOrigin } = props; |
Contributor
Author
There was a problem hiding this comment.
oops, leftover debug code..
Yannick-Malins
requested changes
Dec 5, 2023
Contributor
Yannick-Malins
left a comment
Yannick-Malins
left a comment
There was a problem hiding this comment.
don't merge until SFE-Lite changes are promoted to CORP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description - Do not merge yet
Implements ECP
sendDataAPI (https://github.com/SymphonyOSF/SFE-Lite/pull/14997) in CleverDeal operations page.Do not merge before https://github.com/SymphonyOSF/SFE-Lite/pull/16104 goes to production (24.1). It updates the design of the message generated by the
sendDatafunction.This allows to reflect changes from one client to another, when a trade is pending / accepted or rejected for instance:
Screen.Recording.2023-12-05.at.17.29.01.mp4