Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 9, 2025

🤖 New release

  • arrow_convert_derive: 0.11.0 -> 0.11.1
  • arrow_convert: 0.11.0 -> 0.11.1 (✓ API compatible changes)
Changelog

arrow_convert_derive

0.7.1 - 2024-09-30

Other

  • Introduce rustfmt.toml for consistent formatting
  • Expose arrow_schema on structs with >1 column

arrow_convert

0.11.1 - 2025-11-09

Other

  • review
  • Make schema arrow compliant for Uuid
  • Add Debug to UuidBuilder
  • Implement vec for Uuid
  • make uuid an optional feature
  • review
  • Add support for Uuid for ArrowDeserialize and ArrowSerialize


This PR was generated with release-plz.

@gooroo-dev
Copy link

gooroo-dev bot commented Nov 9, 2025

Please double check the following review of the pull request:

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • 🛠️ Updated version number from 0.11.0 to 0.11.1 in Cargo.toml and workspace dependencies.
  • 🛠️ Added changelog entries for version 0.11.1 including:
    • Making schema Arrow compliant for Uuid.
    • Adding Debug trait to UuidBuilder.
    • Implementing Vec for Uuid.
    • Making uuid an optional feature.
    • Adding support for Uuid for ArrowDeserialize and ArrowSerialize.
    • Some review notes.

Identified Issues

ID Type Details Severity Confidence
001 💪Best Practices The changelog entries contain vague "review" notes that do not clarify what was reviewed or changed. (arrow_convert/CHANGELOG.md lines 9-19) 🟡 Low 🟡 Low

Issue 001

Explanation

The changelog includes entries like "- review" twice without further explanation. This is not informative for users or maintainers reading the changelog.

Suggested fix

Replace vague "review" entries with meaningful descriptions or remove them if they do not represent actual changes.

Code fix

-+### Other
-
-- review
-- Make schema arrow compliant for Uuid
-- Add Debug to UuidBuilder
-- Implement vec for Uuid
-- make uuid an optional feature
-- review
-- Add support for Uuid for ArrowDeserialize and ArrowSerialize
+### Other
+
+- Make schema arrow compliant for Uuid
+- Add Debug to UuidBuilder
+- Implement vec for Uuid
+- Make uuid an optional feature
+- Add support for Uuid for ArrowDeserialize and ArrowSerialize

Explanation of the fix

Removing vague "review" entries improves clarity and professionalism of the changelog.

Missing tests

The diff does not include any code changes besides version bumps and changelog updates, so no tests are required for these changes. However, ensure that the new features mentioned in the changelog (Uuid support, Debug for UuidBuilder, etc.) have appropriate tests in their respective commits.

Summon me to re-review when updated! Yours, Gooroo.dev
React or reply to let me know your opinion!

Removed redundant entries and summarized changes related to Uuid support.
@Swoorup Swoorup merged commit 470020c into main Nov 9, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (4ed3ad6) to head (7831c90).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files           9        9           
  Lines        1685     1685           
=======================================
  Hits         1567     1567           
  Misses        118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant