SMU Keithley 6430 -> add list mode

[franz-sweepMe]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @franz-sweepMe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Keithley 6430 Source Measure Unit (SMU) driver by integrating a new 'list mode' capability. This allows the instrument to execute predefined sequences of measurements, such as voltage or current sweeps, or custom lists of values, rather than just fixed-point measurements. The changes include new GUI parameters for configuration, updated data handling for multi-point results, and dedicated methods for instrument setup in list mode.

Highlights

• List Mode Functionality Added: Introduced a comprehensive 'list mode' feature, allowing the Keithley 6430 SMU to perform automated voltage or current sweeps and custom sequences of measurements.
• Enhanced GUI Parameters: Extended the update_gui_parameters method to expose various list mode configuration options to the user interface, including sweep type, start/end values, step/points definition, custom value input, and hold/delay times.
• Dynamic Data Handling: Modified apply_gui_parameters to process list mode settings and dynamically update the returned variables to include 'Timestamp' when list mode is active. The read_result and call methods were updated to handle multi-point data (voltage, current, timestamps) when in list mode.
• Dedicated List Mode Configuration: Implemented a new configure_list_mode method to manage the detailed setup of sweep and custom list parameters on the instrument, including setting start/stop values, step/points, custom value lists, source ranging, trigger count, and delays.
• Communication Timeout: Added a default communication timeout of 5 seconds to the instrument port properties for improved connection stability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/SMU-Keithley_6430/main.py
  • Added port_properties dictionary with a default timeout of 5 seconds.
  • Initialized self.time_stamps as an empty list.
  • Extended update_gui_parameters to include new list mode configuration keys.
  • Modified apply_gui_parameters to parse list mode parameters and conditionally append 'Timestamp' to self.variables, self.units, self.plottype, and self.savetype.
  • Updated configure to conditionally set source mode (FIXed, SWEep, LIST) based on self.list_mode and moved set_measurement_speed calls.
  • Introduced a new method configure_list_mode for setting up sweep or custom list modes on the instrument.
  • Modified apply to return early if self.list_mode is true, bypassing fixed value setting.
  • Updated read_result to parse multiple measurement values (voltage, current, timestamps) when in list mode.
  • Modified call to return [self.measured_voltage, self.measured_current, self.time_stamps] when in list mode.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new 'list mode' functionality for the Keithley 6430 SMU, enabling sweep and custom value lists. While a significant feature, a potential SCPI injection vulnerability exists because several new GUI parameters are used directly in SCPI commands without proper type validation. This could lead to unintended command execution; it is recommended to explicitly cast these parameters to float in apply_gui_parameters. Additionally, there are areas needing attention for correctness and maintainability, particularly with default parameter values, type handling, and logging practices.